Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remarks for exception types and Registry class #38930

Merged
merged 10 commits into from
Jan 3, 2024
Merged

Remarks for exception types and Registry class #38930

merged 10 commits into from
Jan 3, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 1, 2024 •
edited by github-actions bot
Loading

Contributes to #37859

The remaining snippets 5000 errors are for missing F# project files, which I don't plan to address.

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/runtime-libraries/microsoft-win32-registry.md The Microsoft.Win32.Registry class
docs/fundamentals/runtime-libraries/system-accessviolationexception.md System.AccessViolationException class
docs/fundamentals/runtime-libraries/system-exception.md System.Exception class
docs/fundamentals/runtime-libraries/system-invalidcastexception.md docs/fundamentals/runtime-libraries/system-invalidcastexception
docs/fundamentals/runtime-libraries/system-invalidoperationexception.md System.InvalidOperationException class
docs/fundamentals/runtime-libraries/system-notimplementedexception.md System.NotImplementedException class
docs/fundamentals/runtime-libraries/system-notsupportedexception.md System.NotSupportedException class
docs/fundamentals/runtime-libraries/system-typeinitializationexception.md docs/fundamentals/runtime-libraries/system-typeinitializationexception

@dotnet-bot dotnet-bot added this to the January 2024 milestone Jan 1, 2024
@gewarren gewarren marked this pull request as ready for review January 1, 2024 18:50
@gewarren gewarren requested a review from a team as a code owner January 1, 2024 18:50
IEvangelist
IEvangelist approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@gewarren gewarren merged commit 932bcca into dotnet:main Jan 3, 2024
6 of 7 checks passed
@gewarren gewarren deleted the exception-remarks branch January 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @IEvangelist @dotnet-bot